mmistakes/so-simple-theme

Broken language support after upgrading to v3.2.0 and jekyll 4.x

gionn opened this issue · 3 comments

gionn commented

After upgrading from jekyll-theme-so-simple (3.1.2) to jekyll-theme-so-simple (3.2.0), localization seems broken: I still have locale: it set in my _config.yml but labels are in english (e.g. "Read More" link at the end of each article)

update: breakage starts with 3.1.3 and is unrelated to the jekyll upgrade to v4 (happens on jekyll 3.8.6 too)

Before (labels are in italian):
image

After (labels are in english):
image

My Gemfile.lock:

GEM
  remote: https://rubygems.org/
  specs:
    activesupport (5.2.3)
      concurrent-ruby (~> 1.0, >= 1.0.2)
      i18n (>= 0.7, < 2)
      minitest (~> 5.1)
      tzinfo (~> 1.1)
    addressable (2.6.0)
      public_suffix (>= 2.0.2, < 4.0)
    colorator (1.1.0)
    concurrent-ruby (1.1.5)
    cssminify2 (2.0.1)
    em-websocket (0.5.1)
      eventmachine (>= 0.12.9)
      http_parser.rb (~> 0.6.0)
    ethon (0.12.0)
      ffi (>= 1.3.0)
    eventmachine (1.2.7)
    execjs (2.7.0)
    faraday (0.15.4)
      multipart-post (>= 1.2, < 3)
    ffi (1.11.1)
    forwardable-extended (2.6.0)
    gemoji (3.0.1)
    html-pipeline (2.12.0)
      activesupport (>= 2)
      nokogiri (>= 1.4)
    html-proofer (3.11.1)
      activesupport (>= 4.2, < 6.0)
      addressable (~> 2.3)
      mercenary (~> 0.3.2)
      nokogiri (~> 1.9)
      parallel (~> 1.3)
      rainbow (~> 3.0)
      typhoeus (~> 1.3)
      yell (~> 2.0)
    htmlcompressor (0.4.0)
    http_parser.rb (0.6.0)
    i18n (0.9.5)
      concurrent-ruby (~> 1.0)
    jekyll (3.8.6)
      addressable (~> 2.4)
      colorator (~> 1.0)
      em-websocket (~> 0.5)
      i18n (~> 0.7)
      jekyll-sass-converter (~> 1.0)
      jekyll-watch (~> 2.0)
      kramdown (~> 1.14)
      liquid (~> 4.0)
      mercenary (~> 0.3.3)
      pathutil (~> 0.9)
      rouge (>= 1.7, < 4)
      safe_yaml (~> 1.0)
    jekyll-data (1.0.0)
      jekyll (~> 3.3)
    jekyll-feed (0.9.3)
      jekyll (~> 3.3)
    jekyll-gist (1.5.0)
      octokit (~> 4.2)
    jekyll-minifier (0.1.9)
      cssminify2 (~> 2.0)
      htmlcompressor (~> 0.4)
      jekyll (>= 3.5)
      uglifier (~> 4.1)
    jekyll-paginate (1.1.0)
    jekyll-redirect-from (0.15.0)
      jekyll (>= 3.3, < 5.0)
    jekyll-sass-converter (1.5.2)
      sass (~> 3.4)
    jekyll-seo-tag (2.6.1)
      jekyll (>= 3.3, < 5.0)
    jekyll-sitemap (1.3.1)
      jekyll (>= 3.7, < 5.0)
    jekyll-theme-so-simple (3.1.2)
      jekyll (~> 3.6)
      jekyll-data (~> 1.0)
      jekyll-feed (~> 0.9.2)
      jekyll-gist (~> 1.4)
      jekyll-paginate (~> 1.1)
      jekyll-seo-tag (~> 2.4)
      jekyll-sitemap (~> 1.1)
      jemoji (~> 0.8)
    jekyll-watch (2.2.1)
      listen (~> 3.0)
    jekyll-youtube (1.0.0)
      jekyll
    jemoji (0.11.1)
      gemoji (~> 3.0)
      html-pipeline (~> 2.2)
      jekyll (>= 3.0, < 5.0)
    kramdown (1.17.0)
    liquid (4.0.3)
    listen (3.1.5)
      rb-fsevent (~> 0.9, >= 0.9.4)
      rb-inotify (~> 0.9, >= 0.9.7)
      ruby_dep (~> 1.2)
    mercenary (0.3.6)
    mini_portile2 (2.4.0)
    minitest (5.11.3)
    multipart-post (2.1.1)
    nokogiri (1.10.4)
      mini_portile2 (~> 2.4.0)
    octokit (4.14.0)
      sawyer (~> 0.8.0, >= 0.5.3)
    parallel (1.17.0)
    pathutil (0.16.2)
      forwardable-extended (~> 2.6)
    public_suffix (3.1.1)
    rainbow (3.0.0)
    rb-fsevent (0.10.3)
    rb-inotify (0.10.0)
      ffi (~> 1.0)
    rouge (3.8.0)
    ruby_dep (1.5.0)
    safe_yaml (1.0.5)
    sass (3.7.4)
      sass-listen (~> 4.0.0)
    sass-listen (4.0.0)
      rb-fsevent (~> 0.9, >= 0.9.4)
      rb-inotify (~> 0.9, >= 0.9.7)
    sawyer (0.8.2)
      addressable (>= 2.3.5)
      faraday (> 0.8, < 2.0)
    thread_safe (0.3.6)
    typhoeus (1.3.1)
      ethon (>= 0.9.0)
    tzinfo (1.2.5)
      thread_safe (~> 0.1)
    uglifier (4.1.20)
      execjs (>= 0.3.0, < 3)
    yell (2.2.0)

PLATFORMS
  ruby

DEPENDENCIES
  html-proofer
  jekyll (~> 3.6)
  jekyll-feed
  jekyll-minifier (= 0.1.9)
  jekyll-redirect-from
  jekyll-theme-so-simple
  jekyll-youtube
  jemoji

BUNDLED WITH
   2.0.1

Thanks.

You’re probably missing the translation data file. Verify you have _data/text.yml in your repo.

gionn commented

You’re probably missing the translation data file. Verify you have _data/text.yml in your repo.

Yeah, I've added text.yml back and now it's working again with the latest version.

I was thinking that it was supposed to be present on my project only if I need to override the default translations, looks like it changed since the last few versions.

Thank you!

Data files aren't pulled in from the gem theme with the new version anymore, that's why it stopped working.

English is baked into the theme, and if you want to override any of that you need to include the translation texts I linked to above or localize however you'd like.