mmistakes/so-simple-theme

lunr in this project is not supporting Japanese (lacked script).

liqsuq opened this issue · 3 comments

liqsuq commented

I'm not familiar at this module, but it will be needed upstream's tinyseg.js for lunr supporting Japanese.
Could you add this file and modify /_includes/lunr-search-scripts.html?

MihaiValentin/lunr-languages#42
https://github.com/MihaiValentin/lunr-languages/edit/master/tinyseg.js

mmistakes commented

If you require loading additional JavaScript consult the theme's documentation. You can use the footer_scripts array in _config.yml to load additional scripts of your choosing.

https://github.com/mmistakes/so-simple-theme#customizing-javascript

liqsuq commented

I tried above, but not succeeded. Search result was not indicated.
It might need to be loaded after lunr.stemmer.support.min.js and before lunr.ja.min.js.

It doesn't matter I custom /_includes/lunr-search-scripts.html.
But don't you matter the embedded module is not working?

stale commented

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.