mocaccinoOS/mocaccino

Merging marvin request "update provide" cause inconsistency with quay.io images

Opened this issue · 0 comments

In last releases (at least 0.4.2, 0.4.3 and 0.4.4), there is inconsistency between image tag needed by luet to build package and images stored in quay.io.

An exemple to clarify : in tag v0.4.4 :
luet tree images layers/qt give
layers/system-x-0.20210902+1: luet/cache:80eed97ca971c08c47f111a650d58b672d6a9223507c2b53fdaf5e3562938c83 layers/codecs-3+14: luet/cache:5da7aca1daba6ca8be30c601a57b2a5fc052fef42b31a81e5e9151316b9b746b layers/net-tools-0.2+13: luet/cache:746f9fbe94ce1f623e94d250b7ec6d764d4d2f3d832205b5bc29af475c54267a layers/sys-fs-0.5+51: luet/cache:f066878233182fd924f61f56da88519712c59ca3ce51714c1be5d7771176ce96 layers/X-0.8+16: luet/cache:edd3d99bc2483c356225308439c60dc5ddfebd8092933e97c2a5820ab8e3c4bd layers/qt-5.15.2+58: luet/cache:a485d8b0b565b504ae2fba8150c84ebd0a65395b85a1c236e4b246000ba8969e

but those tags are not store in quay.io (tag for layers/gentoo-portage-0.20210907 is here, tags for system-x and revdep are not)

On HEAD~5 from tag v0.4.4 (commit "2cbcbfee reverse dep: bump apps/gnumeric for layers/gentoo-portage (#206)")
luet tree images layers/qt give
layers/system-x-0.20210902+1: luet/cache:302f340ecc7a7ec38704e65860129a987475b93a41bb36cc1ac09010b349544e layers/codecs-3+14: luet/cache:2355646eb9b4569030f884777e7c8811e9f0cd79f96a8f65ed469331e0203497 layers/net-tools-0.2+13: luet/cache:ea3e2a8176c6869c0179dc4c35fd9903f1823db9322c22d93c01e3cd2c454d61 layers/sys-fs-0.5+51: luet/cache:66e1233c3710426e1c19f876903f40e062c1744e649a710c63c17a14cca94864 layers/X-0.8+16: luet/cache:a84e10ea79c099f7ca92f6524ee394e13f9f860e7750ccb46d585962eb4c9795 layers/qt-5.15.2+58: luet/cache:a3f72c108818299960cf282f6bfce2b7b7eb6ef5110f7e54d756fbfb624d320b

Those tags are those stored in quay.io.

What happen : when merge request 206 (autobump) was merged, those package (layers/system-x-0.20210902+1, layers/net-tools-0.2+13, ...) were compiled and pushed to minio.
After that, when merging request 222 (update provide) was merged, build.yaml file are altered, but version number were not modified. This change tag given/needed by luet.
But since package with these specific version exist in minio, they were not recompiled after provide change and during release.

Suggestion :

  • on release, tag the auto bump commit and not the provide update commit. That's not really clean, and it does not ensure image are on quay.io (for exemple layers/qt-5.15.2+58: luet/cache:a3f72c108818299960cf282f6bfce2b7b7eb6ef5110f7e54d756fbfb624d320b is missing)
    or (I think better)
  • on release, for a full build of the repo in a clean build folder, ensuring every image are computed at that moment.

I think the second option is cleaner, but @mudler @geaaru may have a different feeling.