modelmat/sphinxcontrib-drawio

Figure out why pypi releases do the release but then fail

modelmat opened this issue · 2 comments

It seems to be uploading the release twice? No idea why

I'm not sure, but my guess is it is related to the triggers:

on:
pull_request:
branches:
- master
push:
branches:
- '*'
tags:
- '*'
create:
tags:
- '*'

Because the workflow sometimes runs several times for single commit, for example when I pushed and tagged 373b54f:

image
source: https://github.com/modelmat/sphinxcontrib-drawio/actions

In this case, it one is a create event and the other two are push events (one push event isn't tagged, so doesn't trigger a release). So I'm thinking maybe the create tag event is in a race event with the push tag event and the fix is to only trigger tags on push or create (not sure best practice).