modelon-community/fmi-library

Windows expat prefix bug

Closed this issue · 1 comments

Objexx commented

In FMIL 2.4.1 Config.cmake/fmixml.cmake line 210 is:

"${CMAKE_BINARY_DIR}/ExpatEx/install/lib/${CMAKE_STATIC_LIBRARY_PREFIX}expat${CMAKE_STATIC_LIBRARY_SUFFIX}"

but I believe it should be:

"${CMAKE_BINARY_DIR}/ExpatEx/install/lib/${EXPAT_LIB_PREFIX}expat${CMAKE_STATIC_LIBRARY_SUFFIX}"

Without this fix on Windows the make install looks for expat.lib instead of libexpat.lib and fails.

modelonrobinandersson commented

Hi @Objexx!
Sorry for the late reply, seems that it has been updated since you reported it, see

fmi-library/Config.cmake/fmixml.cmake

Line 243 in 9c6a934

set(expatlib "${CMAKE_BINARY_DIR}/ExpatEx/${EXPAT_LIB_PREFIX}expat${CMAKE_STATIC_LIBRARY_SUFFIX}")

I will close this for now but if you still encounter any issues let me know and I will reopen this.