modlinltd/django-advanced-filters

Modal does not respect dark mode

VaZark opened this issue · 4 comments

VaZark commented

Describe the bug
When the search modal is opened in a browser that has dark mode by default. The theming support was added in django 3.2 (link)

To Reproduce
Steps to reproduce the behavior:

  1. Set browser to prefer dark mode
  2. Open the advanced filter modal on any page

Expected behavior
The modal should respect the CSS variables from django 3.2

Screenshots
image

Details (please complete the following information):

  • OS: linux
  • Python version : 3.9
  • Django version : 4.0
  • django-advanced-filters version : 2.0.0
  • Browser : Firefox
  • Version : 10
asfaltboy commented

Thanks @VaZark , I switched to the var(--body-bg) in PR #176 . Could you give a try and let me know if it resolves your concern? My hope is it's a tiny bit simpler than the changes proposed in PR #173

VaZark commented

Looks like the there one little field that has not been updated

image

asfaltboy commented

Thanks for reminding me about it 🙇

Django has an autocomplete.css select2 theme (see here) that seems to do the job. We can play around with select2 themes in the draft PR #177 , as it switched to django vendored select2 v4.