modularscale/modularscale-sass

Deprecation Warnings

davidhellmann opened this issue · 8 comments

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("ln-maclaurin")) instead.

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("exp-maclaurin")) instead.

can u fix that? :)

image

Thanks for the issue! I’ll look into this later

@davidhellmann Can you isolate this to this plugin? I’m unable to replicate it. It could be an issue with how exponents are implemented via mathsass or similar.

it’s within the pow.scss
i am at holidays at the moment and i have just my iphone with me.

@davidhellmann What environment are you in and are you running any other plugins?

Also take your time and enjoy your holiday!

I use it within my boilerplate: http://baukasten.io and yes. other plugins are installed but no one uses the pow function

@davidhellmann Thanks! It looks like your issue is here: https://github.com/davidhellmann/generator-baukasten/blob/master/generators/app/templates/___src/assets/css/______tools/_tools.function.pow.scss#L45

Modular scale looks for existing exponent logic and piggy backs on that. This allows people to use non-integer values in their scales IF they have support without overcomplicating the codebase for those who don’t need this feature. There are also ways of implementing exponents in Ruby on Ruby Sass instead of writing them in Sass allowing for dramatic performance gains so leveraging whatever pow function people have is often the most optimal solution.

Hopefully this helps!

Hm, looks like u are right. Shame on me!

no worries glad we found it!