login.php warning : htmlspecialchars() expects parameter 1 to be string, array given

Question

login.php warning : htmlspecialchars() expects parameter 1 to be string, array given

Closed this issue 6 years ago · 5 comments

I keep getting this warning in my logs.
/core/components/login/controllers/web/Login.php : 100) PHP warning: htmlspecialchars() expects parameter 1 to be string, array given

When I look at the login.php file, this is what I can see

98 /* Escape placeholder values */
99 foreach ($phs as $k => $v) {
100 $phs[$k] = htmlspecialchars(str_replace(array('[',']'),array('[',']'),$v)); 
101 }

I am running MODX Revolution 2.5.8-pl, and the login package 1.9.4-pl2

Answer 1 · 2018-02-28T08:13:00.000Z

Should be fixed with 1.9.5. Feel free to reopen it, if thats not the case.

Answer 2 · 2018-02-28T11:51:20.000Z

I'm still getting this error @Jako.

I'm using Login 1.9.5 and MODX 2.6.1.

I have deleted my cache folder and cleared the cache through the menus.

[2018-02-28 12:49:12] (ERROR @ /paas/123/www/core/components/login/controllers/web/Login.php : 100) PHP warning: htmlspecialchars() expects parameter 1 to be string, array given

Answer 3 · 2018-02-28T15:09:38.000Z

Could you try it with this commit: https://github.com/Jako/Login/commit/af1ef88eb734a225cf9bd87742a760cdde03b5eb

Answer 4 · 2018-02-28T17:59:54.000Z

thanks @Jako - going to try the commit now and will report back.

Interestingly, the error seems to be triggered when ever a form (any form) is posted.

Answer 5 · 2018-02-28T18:15:12.000Z

@Jako that seems to of fixed the error.

For clarity, I had a Login form, plus another form (formit) on the same page. If the formit form triggered validation errors, It would trigger the reported Login error in the MODX error log.