Weird crash when trying to create new line after deleting line

[acgollapalli]

How to replicate:

Start with something like this:

(defn hello
 []
 (println "hello world!"))

Put cursor on last line, and ensure you are in normal-mode.
In rapid succession type the following characters. "d, d, i, enter".
The editor crashes.

[mogenslund]

Great. Thank you! For the replicate to work, there should be a 4th line, which is empty and the cursor should be on line 3: "hello world!"
Reproducing with --jframe flag will reveal this stack trace:

Exception in thread "AWT-EventQueue-0" java.lang.IndexOutOfBoundsException
	at clojure.lang.RT.subvec(RT.java:1616)
	at clojure.core$subvec.invokeStatic(core.clj:3829)
	at clojure.core$subvec.invoke(core.clj:3818)
	at liq.buffer$insert_in_vector.invokeStatic(buffer.cljc:48)
	at liq.buffer$insert_in_vector.invoke(buffer.cljc:39)
	at liq.buffer$insert_char$fn__866.invoke(buffer.cljc:565)
	at clojure.lang.AFn.applyToHelper(AFn.java:154)
	at clojure.lang.AFn.applyTo(AFn.java:144)
	at clojure.core$apply.invokeStatic(core.clj:667)
	at clojure.core$update_in$up__6853.invoke(core.clj:6185)
	at clojure.core$update_in$up__6853.invoke(core.clj:6184)
	at clojure.core$update_in.invokeStatic(core.clj:6186)
	at clojure.core$update_in.doInvoke(core.clj:6172)
	at clojure.lang.RestFn.invoke(RestFn.java:445)
	at liq.buffer$insert_char.invokeStatic(buffer.cljc:565)
	at liq.buffer$insert_char.invoke(buffer.cljc:561)
	at liq.buffer$insert_char.invokeStatic(buffer.cljc:568)
	at liq.buffer$insert_char.invoke(buffer.cljc:561)
	at liq.editor$handle_input$fn__1194.invoke(editor.cljc:360)

[mogenslund]

Evaluating this piece of code will also reproduce (but without crashing liquid):

(ns user
  (:require [liq.buffer :refer :all]))

(-> (buffer "aa\nbb\n")
    down
    delete-line
    set-insert-mode
    (insert-char "\n"))

[mogenslund]

These two lines should yield the same result:

(str
  (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\nbb\n") down delete-line set-insert-mode) :liq.buffer/cursor)))
  (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\n") down set-insert-mode) :liq.buffer/cursor))))

; OUTPUT:
; #:liq.buffer{:row 2, :col 0}
; #:liq.buffer{:row 2, :col 1}

They do not. I have created a test and fixed the error and commitet.
(Thank you @acgollapalli . I have seen the error occasionally, but without being able to observe what exactly had happened.)

[acgollapalli]

Thank you! The change fixed the issue for me.

[acgollapalli]

As it turns out: (require '[liq.buffer :refer :all]) (str (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\nbb\n") end-of-buffer set-insert-mode) :liq.buffer/cursor))) (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\nbb\n") down down set-insert-mode) :liq.buffer/cursor)))) #:liq.buffer{:row 3, :col 1} #:liq.buffer{:row 3, :col 1} Doesn’t work either. Reasons are similar. Trying to set-to-insert-mode while column set to 0. I’ll create a pull request with a fix in a bit. Thanks, Akshay C. Gollapalli JNA Square JNASquare.com 281-725-1828 From: Mogens Brødsgaard Lund Sent: Friday, May 22, 2020 1:05 AM To: mogenslund/liquid Cc: acgollapalli; Mention Subject: Re: [mogenslund/liquid] Weird crash when trying to create new lineafter deleting line (#50) These two lines should yield the same result: (str (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\nbb\n") down delete-line set-insert-mode) :liq.buffer/cursor))) (with-out-str (clojure.pprint/pprint ((-> (buffer "aa\n") down set-insert-mode) :liq.buffer/cursor)))) ; OUTPUT: ; #:liq.buffer{:row 2, :col 0} ; #:liq.buffer{:row 2, :col 1} They do not. I have created a test and fixed the error and commitet. (Thank you @acgollapalli . I have seen the error occasionally, but without being able to observe what exactly had happened.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[mogenslund]

Great @acgollapalli . Nice catch. I will be looking forward for the pull request :-)

[acgollapalli]

#52 has been added. Thanks!

[mogenslund]

Fixed long ago.