NamesSpaces of schemas not used #bug

Question

NamesSpaces of schemas not used #bug

Closed this issue 6 years ago · 31 comments

lobster2012-user commented 6 years ago

Input

<SchemaName1>
     <EntityName>

<SchemaName2>
     <EntityName>

Output

public class EntityName

In this case, I will get only one entity, which is an incorrect case of inheritance and navigation (links)

Expected output

namespace SchemaName1
{
     public class EntityName
     {
     }
}

namespace SchemaName2
{
     public class EntityName
     {
     }
}

lobster2012-user commented 6 years ago

All ok.

Answer 1 · 2019-03-18T18:14:13.000Z

Can I see the xml metadata file?
Waiting if not available now.

Answer 2 · 2019-03-18T18:28:26.000Z

I will try to cut out part of the .edmx file tomorrow.

Answer 3 · 2019-03-19T09:32:26.000Z

I updated text.

Answer 4 · 2019-03-27T14:49:54.000Z

The xml metafile contain an element named EntityContainer, which can contain something like:

                         <EntityContainer Name="NorthwindEntities" m:IsDefaultEntityContainer="true" p6:LazyLoadingEnabled="true" xmlns:p6="http://schemas.microsoft.com/ado/2009/02/edm/annotation">
			       <EntitySet Name="Categories" EntityType="NorthwindModel.Category"/>
			       <EntitySet Name="Customers" EntityType="NorthwindModel.Customer"/>
			....
                         </EntityContainer>

Here Customers has namespace NorthwindModel

For the example you show, I suppose that the xml file container include more one namespace, something like:

          <EntityContainer Name="NorthwindEntities" ...........>
               <EntitySet Name="EntityName" EntityType="SchemaName1.EntityName"/>
              <EntitySet Name="EntityName" EntityType="SchemaName2.EntityName"/>

               ....
            </EntityContainer>

Is't right?

Do the xml file contain more than one container?

Answer 5 · 2019-03-27T15:29:41.000Z

<Edmx> <!-- version 3.0 -->
     <DataServices>
           <Schema ns="Namespace1">
                  <EntityType Name="Name1"/>
           </Schema>
           <Schema ns="Namespace2">
                   <EntityType Name="Name1"/>
           </Schema>
      </DataServices/>
</Edmx>

Schema intead of EntityContainer

Answer 6 · 2019-03-27T18:47:37.000Z

A new version 3.2.0.3 that can fix this issue can be downloaded here
Best regards,

Answer 7 · 2019-03-27T18:48:50.000Z

Thank you very much. Tomorrow I will test.

Answer 8 · 2019-03-28T08:22:25.000Z

Unfortunly, this will not work.
You read schema once of first container.

Answer 9 · 2019-03-28T19:04:57.000Z

https://raw.githubusercontent.com/lobster2012-user/odata_samples/master/v4.xml (sample from msdn)
Took from here an example.
Got classes only from the first schema. Hm

Answer 10 · 2019-03-28T21:10:28.000Z

Thanks for the sample data file.
You are correct in your note in the previous comment.
Really Odata v3 is a multi container, but Odata v4 is one and only one container.
I modified the code and generated a code for your sample v4.xml in the attached file.

in your sample, the Schema Namespace="Default" has no EntityType, and the container contains an EntitySet of type BookStore.Window which is not the same as the Window EntityType in the schema 'Schema Namespace="NS"'
So, 'Window EntityType', here, may refer to an external Entity, or the sample should contain schema named BookStore.
Is it right?

        <Schema Namespace="Default" xmlns="http://docs.oasis-open.org/odata/ns/edm">
	  <EntityContainer Name="Container">
		<EntitySet Name="Windows" EntityType="BookStore.Window" />
	  </EntityContainer>
	</Schema>

I, also, generated a sample with a multi container and multi schema with the generated code using the new version(not uploaded yet).

Kindly, can you review the generated code in the attached file and comment for something wrong in the output.
odata-multi-container-v3.zip

Answer 11 · 2019-03-28T23:23:03.000Z

poco-multi-container-v3.cs - all ok

Schema Namespace="Default" has no EntityType, and the container contains an EntitySet of type BookStore.Window

True, not carefully looked.

Is it right? -

It looks like the truth.

v4-xml.cs
Should it be a valid c# code?

Answer 12 · 2019-03-29T00:26:02.000Z

I think that v4-xml.cs is valid c# code. Do you find something wrong?

Answer 13 · 2019-03-29T04:30:53.000Z

Now
public [BookStore.Color Nullable=False] Color {get;set;}

May be Valid
public BookStore.Color Color {get;set;}

Answer 14 · 2019-03-29T21:48:14.000Z

When tracing the type details of the properties (Shape,Color, Point,..), I found that odata client give a silent error (not an exception) like:

"ErrorMessage": "The type 'BookStore.Shape' could not be found."
Type.Definition: BadUnresolvedType:BookStore.Shape

"ErrorMessage": "The type 'BookStore.Color' could not be found."
Type.Definition: BadUnresolvedType:BookStore.Color

That means that the Metadata loose these types and it should not.

But How??

I modified the xml file and replace the namespace of the schema "NS" with "BookStore", then every thing shine like magic :D

I'll give a warning message for such errors (if exist).
Also, this schema is Odata V4 which has one container but may have multi schema.

The attached file have both the modified schema (BookStore instead of NS) and the generated c# code.
Have a look and appreciate your feedback if I missed something.

Answer 15 · 2019-03-29T22:03:24.000Z

It looks good.
Apparently there is a typo on MSDN.

Answer 16 · 2019-03-29T22:35:41.000Z

Thanks for feedback
I will prepare for a new version.

Answer 17 · 2019-04-02T09:07:52.000Z

A new version 3.2.0.7 including fix to this issue can be downloaded from github

Answer 18 · 2019-04-02T09:22:46.000Z

Hm. I see invalid code.1 namespace. JsonProperty attributes without 'using namespace' and empty names.

Answer 19 · 2019-04-02T10:01:13.000Z

The version pass all unit test and also tested with the following services:
http://services.odata.org/V4/Northwind/Northwind.svc
http://services.odata.org/V3/Northwind/Northwind.svc
http://services.odata.org/V2/Northwind/Northwind.svc
http://services.odata.org/V4/TripPinServiceRW
and the schema that I posted in the previous comment and MS dynamic365 crm service(3000+ entity).

kindly, can you provided me with a sample of the xml schema
only the header of the meta service and a dummy entity one per schema.
The schema may be incompatible with OData standard.
This can help in fixing the error.

Answer 20 · 2019-04-02T10:47:41.000Z

The attached file is a new version that can dump error message detail as a json string
, like:

          edmTypeReference Error: [
	  {
		"$id": "1",
		"ErrorLocation": {
		  "$id": "2",
		  "LineNumber": 8,
		  "LinePosition": 10
		},
		"ErrorCode": 225,
		"ErrorMessage": "The type 'BookStore.Shape' could not be found."
	  }
	]
	
	Invalid Type Reference: BadUnresolvedType:BookStore.Shape

O2Pgen.zip

Try it and, if possible, post sample of these errors.

Answer 21 · 2019-04-02T17:58:52.000Z

This version is good.
At work then check again.
"https://raw.githubusercontent.com/lobster2012-user/odata_samples/master/v3_multischema.xml?"

//------------------------------------------------------------------------------
// <auto-generated>
//     This code was generated using  OData2Poco System.
//     Service Url: 
//     MetaData Version: 1.0
//     Generated On: 2019-04-02T20:55:58
// </auto-generated>
//------------------------------------------------------------------------------
//
using System;
using System.IO;
using System.Collections.Generic;

namespace ODataDemo
{
	public partial class Supplier
	{
	    public int ID {get;set;} //PrimaryKey not null

	    public string Name {get;set;} 

	    public int Concurrency {get;set;} // not null

	}

	public partial class Supplier2 : Supplier
	{
	    public string Code {get;set;} 

	}

}
namespace ODataDemo2
{
	public partial class Supplier
	{
	    public int ID {get;set;} //PrimaryKey not null

	    public string Name {get;set;} 

	    public int Concurrency {get;set;} // not null

	}

	public partial class Supplier2 : Supplier
	{
	    public string Code {get;set;} 

	}

}

Answer 22 · 2019-04-02T20:07:49.000Z

Glad that it works as you expect.

Answer 23 · 2019-04-03T08:28:51.000Z

Some problems on prod. Can I email my schema to you? (later)

Answer 24 · 2019-04-03T11:17:58.000Z

Yes, you can.
My email: moh.hassan20@gmail.com

Answer 25 · 2019-04-05T13:05:03.000Z

Hi @lobster,
what about the last version?

Answer 26 · 2019-04-05T13:24:19.000Z

Hi, @moh-hassan .With the latest version, everything is bad if we are talking about 3 2 07. Do you get a valid file on output a move without errors and warnings during building?

Answer 27 · 2019-04-05T14:20:17.000Z

I sent you a beautiful generated schema :D without errors /warning and a new version 3.2.0.8
I compiled the generated code with zero compilation error in net45,net461 and netstandard2.
Can you check.
Let me know if you have any questions.

Answer 28 · 2019-04-05T14:31:00.000Z

Thank. I'll see later.

Answer 29 · 2019-04-09T22:24:03.000Z

I reviewed the c# code and the xml schema, the next are some finding:

The class:

   public partial class RepoTradesListItem : ListItem

has no property as a primary key and inherit from ListItem

Its property:
```
 	public int? ID {get;set;} 
```

is null and it's not related to the Id property in the parent ListItem.

Most classes in the Sharepoint schema has the property Id (not ID) as the Pk

The class ListItem, in the xml file, line 989:

  		<EntityType Name="ListItem" BaseType="SP.SecurableObject" OpenType="true">

and it's generated as:

	    public partial class ListItem : SecurableObject

The class is generated without PK and it has no PK in the xml schema
but ListItem has the property:

          [Required]
      public int Id {get;set;} // not null

Sharepoint extension.This is an overhead .Need a system with plugins.

I think that the client deserialize the payload based on the schema defined in the xml file and not
referencing any external classes outside the xml, and ListItem is exist.

I think that the schema is generated properly.

We agreed in the last discussion that type will be the fullName including namespace

Do you have any comments related to the generation code?

Answer 30 · 2019-04-17T18:29:24.000Z

Implemented.