mohsinulhaq/react-popper-tooltip

Husky is dev-dependency, but part of postinstall script

dyst5422 opened this issue · 8 comments

dyst5422 commented

Describe the bug
Husky is dev-dependency, but part of postinstall script, so you get an error on install like

npm ERR! code 127
npm ERR! path /Users/jdstewar/gitRepos/uplink-dashboard/node_modules/react-popper-tooltip
npm ERR! command failed
npm ERR! command sh -c husky install
npm ERR! sh: husky: command not found

To Reproduce
Try to install react-popper-tooltip

Expected behavior
No errors about missing dev-dependencies

mohsinulhaq commented

it was an issue in an older version
are you installing the latest version (v4.2.0) and still getting the same issue?

dyst5422 commented

I believe so. It looks to be an issue in 4.2.0 based on the package.json file https://github.com/mohsinulhaq/react-popper-tooltip/blob/v4.2.0/package.json

mohsinulhaq commented

@dyst5422 works for me. Can you please try installing the latest version once again?
Basically we had added pinst package so that husky is slated for install only in dev mode.

image

If it still doesn't work, please mention the OS and the Node version.

mohsinulhaq commented

closing this as resolved

distinctdan commented

I'm running into this issue also, I should be on the latest versions of everything.
OS: Mac Big Sur 11.6
"@popperjs/core": "^2.10.2"
"react-popper": "^2.2.5",
"react-popper-tooltip": "^4.3.0",

Is there a known workaround? I'd like to avoid having to install husky.

distinctdan commented

To add onto this, I can't add husky either because husky requires the package.json to be at the root of the project with the .git folder, which isn't an option for the project I'm on.

Unfortunately, this makes this library impossible to use for me.

mohsinulhaq commented

@dyst5422 @distinctdan can you guys try out v4.3.1 and let me know if it fixes your issue?

dyst5422 commented

I moved away from this library as a solution and so no longer have a good test case for it.

  • 👍1