Following scss includes and downloading them does not respect paths

Question

Following scss includes and downloading them does not respect paths

Closed this issue 8 years ago · 6 comments

if you have an asset foo that includes _bar and foo/baz , and foo/baz includes _bar (locally under foo/) it will not be downloaded automatically.

jhthorsen commented 8 years ago

Thanks!

Answer 1 · 2016-10-31T20:15:20.000Z

Could you provide an example project (sass project on github or something) where this happens?

Answer 2 · 2016-10-31T20:20:13.000Z

Including https://raw.githubusercontent.com/select2/select2/master/src/scss/core.scss will cause this issue.

Answer 3 · 2016-11-13T16:12:19.000Z

Now I get it: Pipe::Sass tries to download many different files in order, so it first tries to download "_layout.scss" which it cannot find, but then afterwards it downloads "layout.scss" which does exist. I will see if I can silence the warning somehow, but at least the code works as expected.

if Pipe::Sass fail to download all of the various allowed SASS filenames, it will fail loudly.

https://github.com/jhthorsen/mojolicious-plugin-assetpack/blob/master/lib/Mojolicious/Plugin/AssetPack/Pipe/Sass.pm#L77-L83

Answer 4 · 2016-11-13T16:12:54.000Z

Another thing to fix is that assetpack.db should prevent Pipe::Sass from even trying to fetch the files later on.

Answer 5 · 2017-02-05T23:08:37.000Z

This is now fixed.