mojotech/scrivener_ecto

Page number greater than total_pages should be allowed

Closed this issue · 2 comments

The pull request below breaks a number of clients we have that increment the page until the entries array is empty.

https://github.com/drewolson/scrivener_ecto/pull/43/files

Would you be open to a pull request making this configurable?

Same here. Some endpoints just sent the list of items, other send the total pages, current page, etc. I will convert now all to return total pages, current page, etc.

I'm not interested in allowing pagination beyond the end of the collection. See #71 for a proposed solution.