molgenis/capice-resources

[compare-model-performance] Model 1 and model 2 violinplot can be flipped

Closed this issue · 0 comments

Describe the bug

In the violinplots, model 2 (benign) can be shown before model 1 (benign) in the plot, causing confusion.

System information

  • Version: 5.1.0
  • Python version: 3.11.3
  • Shell: ZSH

Expected behavior

Model 1 benign should always be shown first, then model 2 benign, then model 1 pathogenic, then model 2 pathogenic.

Screenshots

(see frameshift_variant)
score_differences_vio

Additional context

Potential solution: Add sort on "dataset source" on line 903