moltar/typescript-runtime-type-benchmarks

TypeScript 4.1 breaking change

Closed this issue · 1 comments

RA80533 commented

Due to a breaking change introduced in TypeScript 4.1, Promise.resolve() now requires an argument. The most recent builds have been failing due to an offending line in index.ts (shown below):

typescript-runtime-type-benchmarks/index.ts

Line 97 in 4103dc7

return new Promise((resolve, reject) => {

moltar commented

Awesome! Thank you for the fix.

I also just added a bunch of fixes to test the actual builds during PR actions to prevent this in the future.

I was only running jest tests, but wasn't running tsc.