momi-foundation-coding/nodejs-api-cli

Improve folder structure for tests -> all tests in one file

Closed this issue · 9 comments

ezkemboi commented
  • At the moment, when app is created, there is only one test file, where it holds all tests.
  • It is better to have controller testing, middlewares or other items be in their own folder.
  • Also, it should make sure that tests are running.
its-tayo commented

Hi @ezkemboi can I have a go at this please?

  • 👍1
  • 🎉1
ezkemboi commented

Sure, thanks and welcome.
Go ahead and rais a PR.

  • 🚀1
ezkemboi commented

Assigned to you @its-tayo.

its-tayo commented

Hi @ezkemboi, can you please let me know what the new test directory structure should look like?

ezkemboi commented

Something like

    tests 
        - controllers
              - user.js
        - middleware
             - middleware.js
        - routes
             - routes.js

It might not be good the first time, but the idea is to have different files/folders for different parts that are testable. Something like models might be tested easily when controllers and other items have been tested.
We just want to get rid of the test file being a single file.

In case of any clarification you need or help with the codebase, do let me know.
Looking forward to your PR.

ezkemboi commented

@its-tayo we can schedule a call if you need assistance with any part of the codebase or any assistance whatsoever.

its-tayo commented

Alright, thanks. I went through the codebase thoroughly yesterday, hence the delay. Submitting my pr in a bit. But we could still schedule a call though.

  • 👍1
ezkemboi commented

@its-tayo thanks for your efforts.
I do really appreciate and welcome to the team.
Probably about the call, I will send you an email on the same.

its-tayo commented

You're welcome. Looking forward to our call.

  • 👍1