monal-im/Monal

[Feature]: Streamline code

Closed this issue · 2 comments

tmolitor-stud-tu commented
  • The current code has different names for the same thing: isGroup in MLContact, but isMuc in MLMessage. Use isMuc everywhere.
  • mucType is named same in both files, but is a NSString. Make this an enum having the values channel and group (and unknown, if the db has the value NULL for this information which is needed to trigger a proper update, see 4ac6495).
  • Rename connectedAccounts (and connectedAccount) to enabledAccounts (enabledAccount) everywhere
  • Use accountID as NSNumber everywhere (not accountId or accountNo and not as NSString either).
tmolitor-stud-tu commented

@lissine0 This is complete, right?

lissine0 commented

Yes it is complete (though someone may want to switch from String constants to enums at some point)