mondaycom/vibe

[Bug]: Combobox - when there are no items there is a redundant spacing below the search input

talkor opened this issue · 0 comments

When the list is empty, there's a redundant spacing under the search input which should be removed.

  • Do not render ComboboxItems when there are no items (when hasResults is falsy) ( packages/core/src/components/Combobox/components/ComboboxItems/Combobox.tsx) - which will remove one margin from within the ComboboxItems
  • margin-bottom from .combobox (in packages/core/src/components/Combobox/Combobox.module.scss)

Both spacings should be removed conditionally when there are no items.

See screenshots:

large-image-from-clipboard large-image-from-clipboard (1)

Monday ticket