mondaycom/vibe

docs: fix EditableText and EditableHeading overflowing in the catalog

talkor opened this issue · 5 comments

In the Catalog there are interactive examples of components.

The EditableText and EditableHeading examples are overflowing. See screenshots:
Screenshot 2024-10-09 at 18 28 12

Screenshot 2024-10-09 at 18 28 22

Need to make them stretch, for example like the Heading:
Screenshot 2024-10-09 at 18 28 44

Related files

packages/core/src/storybook/components/related-components/descriptions/editable-text-description.tsx
packages/core/src/storybook/components/related-components/descriptions/editable-heading-description.jsx


Monday ticket [internal]

Hello, I would like to work on this

Hi, I tried it, removing max-width: 100%; inside editableTypography , my guess is it only allows the width of actual text there is, it got expanded but I'm not confident whether it's the right solution. Is there better approach to it?

Reference: packages/core/src/components/EditableTypography/EditableTypography.module.scss

Hi, I tried it, removing max-width: 100%; inside editableTypography , my guess is it only allows the width of actual text there is, it got expanded but I'm not confident whether it's the right solution. Is there better approach to it?

Reference: packages/core/src/components/EditableTypography/EditableTypography.module.scss

Hi @tamirazrab , thanks for looking into it! No need to change the component itself, but probably in the description component listed in the issue description. I believe it's due to the flex container which can be converted to a block

@talkor ,

If this issue is still available for grabs, I'd like to look into it.

@talkor ,

If this issue is still available for grabs, I'd like to look into it.

Sure @mashazyu, that would be great, thank you!