Change `DialogContentContainer` catalog component to use `Text` component
Closed this issue · 2 comments
YossiSaadi commented
In the file of:
packages/core/src/storybook/components/related-components/descriptions/dialog-content-container.jsx
which can be seen on our Catalog page, we do not currently use Vibe's Text
component, but instead use inline string.
It also causes theme issues where a story doesn't look right on dark themes.
<DialogContentContainer>
<p>A content section within an elevated dialog content container</p>
</DialogContentContainer>
--> Something like
<DialogContentContainer>
<Text ellipsis={false}>A content section within an elevated dialog content container</Text>
</DialogContentContainer>
Notice the ellipsis
as false
as well.
monday ticket:
https://monday.monday.com/boards/3532714909/pulses/7080412658
noyshlomo commented
Hi, Can you please assign this to me?
YossiSaadi commented
@noyshlomo go for it :)