mondaycom/vibe

Change "Colors"'s story "Content colors" to use `Text` component

Closed this issue · 4 comments

In the file of:
packages/core/src/storybook/stand-alone-documentaion/colors/content-color-row/content-color-row.jsx
which can be seen on our Colors story page, we do not currently use Vibe's Text component on some of the stories, but instead use inline string.
It also causes theme issues where a story doesn't look right on dark themes.

<tr className="content-color-row">
  <ContentColorCell>{`--${colorName}`}</ContentColorCell>
  <ContentColorCell style={regularStyle} />
  <ContentColorCell style={hoverStyle} />
  <ContentColorCell style={selectedStyle} />
</tr>

--> Something like

<tr className="content-color-row">
  <ContentColorCell>
    <Text>{`--${colorName}`}</Text>
  </ContentColorCell>
  <ContentColorCell style={regularStyle} />
  <ContentColorCell style={hoverStyle} />
  <ContentColorCell style={selectedStyle} />
</tr>

Change the headers of the table as well in packages/core/src/storybook/stand-alone-documentaion/colors/content-colors/content-colors.jsx.

monday ticket:
https://monday.monday.com/boards/3532714909/pulses/7080412658

Hi, Can you please assign this to me?

@noyshlomo go for it :)

Hey @noyshlomo, please update if you still planning on working on that one

Yes, I’m on this today. Thanks!