daemon can send duplicate transactions, causing disconnects
selsta opened this issue · 0 comments
selsta commented
Since #8916 peers that send duplicate transactions gets dropped. This usually isn't an issue, but when running a daemon with --max-txpool-weight
it's possible that duplicate transactions can get into the fluff queue.
Quoting @Boog900 from #9317 (comment)
If you receive a tx, add it to your fluff queue, drop the tx from the txpool, then receive it again, it is added to the fluff queue a second time. When the fluff timer fires we would then broadcast a message with the same tx twice causing the peer to disconnect.
Relevant code:
monero/src/cryptonote_protocol/levin_notify.cpp
Lines 203 to 207 in c821478