ZipFile objects are not automatically disposed after use
Closed this issue · 1 comments
pushedx commented
There are instances of new ZipFile being used in Mono.Addins.Setup that are not automatically disposed, causing file handles to be held much longer than necessary.
AddinPackage.cs (93)
AddinPackage.cs (137) <- This one is fine because the FileStream is disposed, but for the sake of consistency
SetupService.cs (584)
(Lines as of commit 70e9d43)
This is an issue when you want to cleanup mpacks after SetupService.Install is called, but have to wait until the ZipFile handles get disposed (or the application exits), which is undesirable.