Silently ignore native binaries during scanning

Question

Silently ignore native binaries during scanning

KirillOsenkov opened this issue 8 years ago · 6 comments

Mono Addins crashes when encountering a native binary that's not excluded. Maybe it should instead skip it silently?

Answer 1 · 2017-03-27T23:05:43.000Z

Cecil throws a BadImageFormatException when it encounters a native library (CLI Header is empty). Maybe we should catch that, and log the assembly not being loaded.

Answer 2 · 2017-03-27T23:06:12.000Z

Ideally avoid the exception in the first place (I bet Cecil has ways to probe)

Answer 3 · 2017-03-27T23:09:00.000Z

Doesn't look like it does, but this is part of parsing the metadata of a given dll file, so we can safely just catch that exception.

Answer 4 · 2017-03-27T23:14:33.000Z

@jbevain Jb is there a way to detect a native binary in Cecil and avoid throwing an exception?

Answer 5 · 2017-03-27T23:15:16.000Z

Here's how I normally do it: https://github.com/KirillOsenkov/SourceBrowser/blob/master/src/Common/IsManagedAssembly.cs

Answer 6 · 2017-05-14T22:16:30.000Z

Closing as #63 was merged.