buffer_clear_region_channel ignores preserve level
catfact opened this issue · 1 comments
catfact commented
reported on lines:
https://llllllll.co/t/norns-2-0-softcut/20550/281?u=graymazes
use of buffer_clear_region_channel
the parameter reduction_level is between 0 and 1
here the preserve variable has no effect / the same effect as 0:
function gain_reduction()
local preserve = 1 - params:get("reduction_level")
softcut.buffer_clear_region_channel(1, splice[active_splice].s, splice[active_splice].l, 0.01, preserve)
end
it looks to me like these argument count checks are maybe off by one. since arg count is never >5, preserve arg is therefore never read.
https://github.com/monome/norns/blob/main/crone/src/OscInterface.cpp#L722-L730
incidentally i don't think this OSC method is ever used anymore, so it's dead code and should be deleted
https://github.com/monome/norns/blob/main/crone/src/OscInterface.cpp#L688-L693
(unless... is it possible that scripts are sending crone OSC directly?)