monuelo/cast-sh

Not Added as Contributor?

satanb4 opened this issue · 6 comments

satanb4 commented

I haven't been added as contributor for the project after #22 ?

vladdoster commented

Looking at #22, I think it's because you merged into dev, not master. I assume @hericlesme merged it from dev to master. You can see my pr #29 was merging into hericlesme:master.

satanb4 commented

I think it did merge to hericlesme:master. But the base branch got changed from Master to Dev.

  • 👍1
  • 😕1
monuelo commented

@satanb4 I think your git user isn't configured correctly. Please configure the Git author in your commits, as it does not match your Github user.

satanb4 commented

Okay. I got to the bottom of this. Since I was working from a different workstation, the commit history is different. I have recursively changed the Author and Email on my fork, however now I cannot create a pull request since the Git histories have diverged. Will need to be added as a contributor to be able to change the git history on original repo, or @hericlesme can change it as given in Change Author Info.

  • 😄1
monuelo commented

@satanb4 Okay! As soon as possible, I'll do it! 🚀 🎉

  • 🎉1
vladdoster commented

I think this can be closed @hericlesme 👀