Allow multisession
monuelo opened this issue · 4 comments
We actually have just one session per cast-sh instance. The implementation must allow multisession and tabs (each with a child process).
I would like to work on this.
I am going to store sessions in app.config["session_fd"] = {}
and app.config["session"] = {}
To open a new session, I propose that generating a random hash as the ID of the session.
New session is in form of new browser tab with different url (with the value of hash).
And then frontend socket.io would select those relevant output messages to display. But it could be problem that every session could get the others messages though they are not displayed in the terminal. Because all the sessions are subscribing to a single socket.io stream.
@oktak thanks mate. There's a branch called feature/multi-session, I think it could be helpful for you, I suggest you take a look. ;)
Oh! I overlooked a bit. Okay. Actually I wrote some code based on master branch.
I just tried the feature/multi-session
branch. It looks like you has been worked on the tabs with unique ID. I think it is not hard for me to apply what I've worked to that. :)