moodlehq/moodle-plugin-ci

Request: MSSQL support

dionysius opened this issue · 2 comments

dionysius commented

Moodle supports more databases than what moodle-plugin-ci currently offers. In studentquiz/moodle-mod_studentquiz#314 we got the first issue for MSSQL.

We would like to support MSSQL, but to confidently do that, we need to ensure that the testing toolchain can test against it as well.

Is moodlehq willing to add support for MSSQL?

If we are lucky, we only need to document how travis or github actions files need to be written.

kabalin commented

Hi @dionysius, I think it would be great to include MSSQL support. I think this will need:

  • New DB type support changes, i.e. --db-type option description, db resolver code changes, new db class, tests.
  • Docs explaining how to use it in test (including changes gha.dist.yml and travis.dist.yml)
  • Some example showing this works. May be expand self-test CI and add a new stage containing matrix of all supported DBs for Moodle installation step test only (i.e. to make it quick, just to ensure that chosen DB works).

PR with above changes will be very appreciated :)

dionysius commented

There has been a lot of discussion and ideas in the freshly linked issue #128 for oracle DB. I'm not familiar with github actions, but if they support docker images, we could try to use the mssql images provided by microsoft: https://hub.docker.com/_/microsoft-mssql-server

  • 👍1