Remove panics from service
Closed this issue · 1 comments
JoshOrndorff commented
There is some code in the Moonbeam node's service (that I wrote three years ago 😬) that could potentially panic.
moonbeam/node/service/src/lib.rs
Lines 1230 to 1234 in 633cb27
I don't know that it has ever paniced in production, and certainly it doesn't happen often, but of course it is best to handle errors more gracefully when possible.
I recently used similar code in Tuxedo, the UTXO framework for Substrate. And @muraca encouraged me to try to remove the panics. In the end we found a technique that can be used in your node as well. Off-Narrative-Labs/Tuxedo#126
crystalin commented
Thank you @JoshOrndorff ;) , someone in the team will look at it.