would like to develop but cannot build
joelreymont opened this issue · 4 comments
joelreymont commented
This has nothing to do with the go1 branch.
biggie:golang joelr$ cd /tmp
biggie:tmp joelr$ git clone git://github.com/moovweb/gokogiri.git
Cloning into 'gokogiri'...
remote: Counting objects: 3502, done.
remote: Compressing objects: 100% (1721/1721), done.
remote: Total 3502 (delta 1845), reused 3351 (delta 1712)
Receiving objects: 100% (3502/3502), 1.18 MiB | 140 KiB/s, done.
Resolving deltas: 100% (1845/1845), done.
biggie:tmp joelr$ cd gokogiri/
biggie:gokogiri joelr$ go build
# gokogiri/xpath
expression.go:4:26: error: libxml/xpath.h: No such file or directory
expression.go:5:35: error: libxml/xpathInternals.h: No such file or directory
biggie:gokogiri joelr$ git branch
* master
joelreymont commented
The updated go1 branch builds fine.
joelreymont commented
xpath/xpath.go in master refers to xmlXPathContextSetDeadline so it still doesn't build, even after I replace all the references to
#cgo CFLAGS: -I../../../clibs/include/libxml2
#cgo LDFLAGS: -lxml2 -L../../../clibs/lib
with
#cgo pkg-config: libxml-2.0
Then, go1 uses this stile of imports
import (
"github.com/moovweb/gokogiri/html"
"github.com/moovweb/gokogiri/xml"
)
so how do I develop in my own fork of the repo? Do I need to manually adjust the imports and revert them before a pull request?
mdayaram commented
Please use the go1 branch for developing, and file a PR onto the go1 branch here.
joelreymont commented
I figured that manually replacing github.com/moovweb
with github.com/wagerlabs
is the way to go.