mooz/node-icu-charset-detector

NodeJS 6.0.0+: getting deprecation warnings

Closed this issue · 1 comments

Migrating to node v6.0.0 (now i'm using latest v6.1.0) i'm getting this:

==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: CharsetMatch::RegisterClass(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: 0x9561b4
 6: 0x9564fb
 7: 0x41d120961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x11dd5fac9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x41d159dbe4] (this=0x2ccd6b06dd09 <an Object with map 0x35c870517871>#1#,module=0x3806dfc8e699 <a Module with map 0x35c870517e49>#2#,filename=0x3806dfc8e2c9 <String[121]: /home/user/javascript/website/node_modules/node-icu-charset-detector/build/Release/node-icu-charset-detector.node>)
    2: load [module.js:~447] [pc=0x41d175d736] (this=0x3806dfc8e699 <a Module with map 0x35c870517e49>#2#,filename=0x3806dfc8e2c9 <String[121]: /home/user/javascript/website/node_modules/node-icu-charset-detector/build/Release/node-icu-charset-detector.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x41d1338c7d] (this=0x11dd5fa04189 <undefined>,module=0x3806dfc8e699 <a Module with map 0x35c870517e49>#2#,filename=0x3806dfc8e2c9 <String[121]: /home/user/javascript/website/node_modules/node-icu-charset-detector/build/Release/node-icu-charset-detector.node>)
    4: _load [module.js:407] [pc=0x41d13348c2] (this=0x2ccd6b06dd89 <JS Function Module (SharedFunctionInfo 0x39ab3a729609)>#3#,request=0x1cfa28cadbf1 <String[41]: ./build/Release/node-icu-charset-detector>,parent=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,isMain=0x11dd5fa04299 <false>)
    5: require [module.js:~463] [pc=0x41d13ec52b] (this=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,path=0x1cfa28cadbf1 <String[41]: ./build/Release/node-icu-charset-detector>)
    6: require(aka require) [internal/module.js:20] [pc=0x41d1343866] (this=0x11dd5fa04189 <undefined>,path=0x1cfa28cadbf1 <String[41]: ./build/Release/node-icu-charset-detector>)
    7: /* anonymous */ [/home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js:1] [pc=0x41d1cbe539] (this=0x3806dfc8be21 <an Object with map 0x21b3cf907b71>#5#,exports=0x3806dfc8be21 <an Object with map 0x21b3cf907b71>#5#,require=0x3806dfc8d319 <JS Function require (SharedFunctionInfo 0x39ab3a75ac71)>#6#,module=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,__filename=0x3806dfc8ba11 <String[105]: /home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js>,__dirname=0x3806dfc8d2b1 <String[76]: /home/user/javascript/website/node_modules/node-icu-charset-detector>)
    8: _compile [module.js:541] [pc=0x41d1341c24] (this=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,content=0x3806dfc8c7f1 <Very long string[1725]>#7#,filename=0x3806dfc8ba11 <String[105]: /home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js>)
    9: .js [module.js:~548] [pc=0x41d196f304] (this=0x2ccd6b06dd09 <an Object with map 0x35c870517871>#1#,module=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,filename=0x3806dfc8ba11 <String[105]: /home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js>)
   10: load [module.js:~447] [pc=0x41d175d736] (this=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,filename=0x3806dfc8ba11 <String[105]: /home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js>)
   11: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x41d1338c7d] (this=0x11dd5fa04189 <undefined>,module=0x3806dfc8bdd1 <a Module with map 0x35c870517e49>#4#,filename=0x3806dfc8ba11 <String[105]: /home/user/javascript/website/node_modules/node-icu-charset-detector/node-icu-charset-detector.js>)
   12: _load [module.js:407] [pc=0x41d13348c2] (this=0x2ccd6b06dd89 <JS Function Module (SharedFunctionInfo 0x39ab3a729609)>#3#,request=0x39ab3a75e259 <String[25]: node-icu-charset-detector>,parent=0x3806dfc7f8f1 <a Module with map 0x35c870517e49>#8#,isMain=0x11dd5fa04299 <false>)
   13: require [module.js:~463] [pc=0x41d13ec52b] (this=0x3806dfc7f8f1 <a Module with map 0x35c870517e49>#8#,path=0x39ab3a75e259 <String[25]: node-icu-charset-detector>)

@mooz take a look to the PR please