iOS 7 alert support

Question

iOS 7 alert support

Opened this issue 11 years ago · 24 comments

Hey Guys, are there any plans to support iOS 7 in the near future? At the moment we are having problems localizing alerts on the screen.
Both commands below do not return any element of the view, even though the alert is displayed properly.

frankly_map("view: '_UIModalItemAlertContentView' view:'UILabel', "accessibilityLabel")

frankly_map('alertView', 'message')

Answer 1 · 2013-08-31T11:35:01.000Z

I guess we should wait until the iOS 7 functionality is completed. Especially alerts are still a bit buggy.

Answer 2 · 2013-09-14T18:43:04.000Z

I am planning to go a bit deeper but from my last tests, it seems that Apple is somehow blocking the access to private classes. I am planning to inspect this.

The old alertView selector won't work since UIAlertView is not part of the view hierachy any more on iOS 7. Also, there are no buttons (UIButton). Everything is implemented through tables.

Answer 3 · 2013-09-14T22:52:17.000Z

I will push a fix next week. To summarize the issue:

Apple decided to make the modal window a system window. System windows are not returned by -[UIApplication windows]

The view hierarchy is still visible in Symbiote because Symbiote uses only -[UIApplication keyWindow]. However, Shelley uses only -[UIApplication windows].

Answer 4 · 2013-09-29T10:35:34.000Z

Hi Ondrej,

As I can see your recent pull request is not enough for solving the issue with alert views - they are still out of scope by Shelly engine though visible via Symbiote. Do you have any plans to continue working on this issue?

Answer 5 · 2013-09-29T10:46:35.000Z

Yes, but I am still deciding how to do it. Shelley can either check whether FEX_windows is available on UIApplication or I can duplicate the whole code in Shelley.

Answer 6 · 2013-09-29T19:31:40.000Z

Could you please take a look at these pull requests? I think I've found some sort of solution for this issue.

#248
TestingWithFrank/Shelley#11

Answer 7 · 2013-09-29T20:48:03.000Z

@ondrejhanslik I really like @oradyvan's approach. Basically a delegate protocol which Frank implements and provides to the selector engine. Seems nice and clean. I am planning to pull it in but of course would love to get your thoughts on it.

Answer 8 · 2013-09-29T21:01:54.000Z

Thank you guys, I just updated both pull requests, please take a look.

Answer 9 · 2013-10-10T08:29:46.000Z

Hi guys,

What about Shelley change?

Was it applied?

We are in company really heavy rely on Frank automation testing and with iOS 7 it's now really broken )

What is the thoughts about upcoming Frank releases?

Regards,
Andrey

Answer 10 · 2013-10-10T16:57:22.000Z

I'm in the same boat as Andrey.
Any progress on the new iOS7 changes?

Answer 11 · 2013-10-14T17:59:21.000Z

I must have missed this, but I've taken a similar but (I think) simpler approach here:
#250

This is a backwards compatible change to the selector engine protocol and passes along the windows using the new FEX_windows category method.

I've updated the Igor selector engine to support this here:
lukeredpath/igor@74d7e95

With these changes, I was able to get my UIAlertView tests working by replacing references from UIAlertView to _UIModalItemRepresentationView.

Answer 12 · 2013-10-23T17:27:06.000Z

@lukeredpath; will you be doing the change to Shelley? I've posted this question on the Google group but have received no answer as to when the fix for the old UIAlertViews will be provided. I've pulled your fix and I tried ondrejhanslik's fix but none work. I guess these solutions are only partially completed?

Thanks!

Answer 13 · 2013-10-23T18:40:41.000Z

@athenatk probably not as I don't really use Shelley.

Answer 14 · 2013-11-11T18:32:53.000Z

With #250 and TestingWithFrank/Shelley#16, I assume that this bug is now fixable (pending travis supporting Xcode 5 for TestingWithFrank/Shelley#15)

Answer 15 · 2013-11-20T19:32:01.000Z

TestingWithFrank/Shelley#17, TestingWithFrank/Shelley#16 & TestingWithFrank/Shelley#15 just got merged which opens up the possibilities of iterating through multiple windows to find the UIAlertView. Should this repo be updated to use the latest Shelley, or should the fix for this bug go into the https://github.com/TestingWithFrank/Frank repo?

Answer 16 · 2013-11-27T15:17:55.000Z

sorry for the newbie question, but, how can I do to touch an alert view button?

Answer 17 · 2013-12-04T09:45:21.000Z

A variation of https://gist.github.com/seanoshea/7613671 seems to be working fine for me after updating to the latest version of Frank and Shelley.

I can't seem to access the frankly_os_version function though. Do I need to update my gems or something to get that working? Apologies for the n00b-ish question - a lot of this ruby stuff is pretty new to me.

Answer 18 · 2013-12-04T09:50:38.000Z

You need to make a release build (using the rake) and then you can install the gem from the resulting package (I think the command is igem install --local)

Answer 19 · 2013-12-07T12:41:14.000Z

#260 allows the title of a UIAlertView be queryable. Need to work on the message being queryable and clicking on the buttons too.

Answer 20 · 2014-03-23T18:41:04.000Z

Hi guys,

are there any news or plans in making the alert views clickable for iOS7?

Answer 21 · 2014-03-24T08:40:16.000Z

@dgmora ... the following could work for you:

When /^I touch the alert button marked "([^\"]*)"$/ do |mark|
  quote = get_selector_quote(mark)
 if frankly_os_version > "7.0"
    touch_with_sleep( "view:'_UIModalItemTableViewCell' marked:#{quote}#{mark}#{quote}" )
  else
    touch_with_sleep( "view:'UIAlertButton' marked:#{quote}#{mark}#{quote}" )
  end
end

Answer 22 · 2014-04-10T09:52:09.000Z

@seanoshea Thanks, couldn't find that before!

Answer 23 · 2014-04-23T00:08:47.000Z

@seanoshea Do you have source code for touch_with_sleep method by any chance? I got the NoMethodError when I tried to use your code.

Answer 24 · 2014-04-23T08:09:48.000Z

this is a custom function we use in our code. It's basically just a wrapper around touch. So you should be able safe replace that with touch.