morepurplemorebetter/MPMBs-Character-Record-Sheet

Paladin prepared spells rounding up (should round down)

malaclypse1 opened this issue · 3 comments

Paladins are getting their level/2 rounded up in prepared spells - PHB says it should be rounded down.

I am very certain that the sheet (v12.999) rounds the number of spells to prepare down. This is the code for it, and it uses Math.floor().

So I'm closing this issue. However, I'm happy to help you with your character sheet to see why it is doing what it is doing. Perhaps you added a modifier for spell preparation or forgot that it is also adding your ability modifier?
You can send me a copy to your character sheet (or post a link to it) and I'll have a look.

Also, if you are going to report an error like this, it would be very helpful to know the version number of the sheet that you are using, as well as the version number of Adobe Acrobat and the type and version of your operating system (e.g. Windows 10).

I appreciate your time (and your great sheet). You can reproduce this bug by opening a new, unmodified sheet, selecting paladin as a class, and any odd level higher than 1. Create the spell sheet, select prepared spells only, and you get this screenie

If you generate a sheet with known spells, it shows spells to prepare correctly, so that implies the javascript dialog for generating a prepared spellsheet is where the error is. I think it might be here where you use ASround (and thus Math.round) to determine how many prepared spell dropdowns to show.

You are absolutely right! I didn't think of the selection dialog for prepared spells. It would have been helpful if you mentioned that in the initial description of the issue, but we got there :)

For some reason I assumed the calculated spellcasting level would be correct to use for the amount of spells to prepare, but that is incorrect, because the adjusted spellcasting level has to be rounded up, while the amount of spells to prepare has to be rounded down.

With 'adjusted spellcasting level' I mean the way the sheet takes the default spell slot progression and applies it to classes with 1/2 (paladin) or 1/3 (arcane trickster) spell progression. For those classes, the effective level is rounded up for some reason. Just compare the paladin spell slots per level with those of the wizard, and you'll see that a 7th level paladin has the same slot as a 4th level wizard.

Anyway, thank you very much for reporting this issue. I have fixed it with this commit, so it will be part of the next version of the sheet!