morganstanley/binlog

Don't force build type on non standalone builds

Closed this issue · 2 comments

andrewkcorcoran commented

For standalone builds of binlog it's probably fine to force an unspecified CMAKE_BUILD_TYPE to be RelWithDebInfo. However setting this value in a non standalone build affects all other projects which are being built.

erenon commented

Does it matter when binlog is built as part of a source tree, via cmake include? Then it could be resolved by splitting the main CMakeLists.txt, as it also affects other settings (eg standard to be used) OR by making those settings conditional. Ill see which approach yields to simpler code.