morganstanley/modern-cpp-kafka

DEBUG confliction

zjufish opened this issue · 2 comments

zjufish commented

it looks like below code conflicts with system DEBUG macro and produces a compile error with gcc10.1.0. should we use a different name or remove it given it is not used at all in code anyway?

: error: expected unqualified-id before numeric constant
kafka/KafkaClient.h:198:34: note: in expansion of macro ‘DEBUG’
198 | static const constexpr char* DEBUG = "debug";

kenneth-jia commented

Thanks, @zjufish!
As you said, the DEBUG is not used anymore, we should just remove it from kafka/KafkaClient.h.

zjufish commented

please make a fix and retag. thanks.