morkro/vue-a11y-dialog

Alert dialog overlay

roblevintennis opened this issue · 4 comments

I think I may have made a mistake in the alert dialog implementation for alert dialog role case…

See:
https://github.com/morkro/vue-a11y-dialog/blob/main/src/A11yDialog.vue#L12

and
https://github.com/morkro/vue-a11y-dialog/blob/main/src/A11yDialog.vue#L12

Notice we only omit the close handler but not the attribute.

And then if we read @KittyGiraudel instructions for this:
https://a11y-dialog.netlify.app/advanced/alert-dialog

I suppose the fix might look like :data-a11y-dialog-hide="role === 'alertdialog' ? undefined : true" or in context:

    >
      <div
        :data-a11y-dialog-hide="role === 'alertdialog' ? undefined : true"
        tabIndex="-1"
        :class="classNames.overlay"
        @click="role === 'alertdialog' ? undefined : close"
      />

I'm happy to make the change next spare cycle I get @morkro

Yep, seems that this needs to be fixed. :)

Ok, I've made an issue in my own repo at AgnosticUI/agnosticui#137 so I remember to do address this next week. Thanks for confirming.

#39 fixes this issue.

Thanks @roblevintennis—released 1.1.2 :)