Clicking "Dismiss Difference" [X] button does nothing + spelling error in tooltip

Question

Clicking "Dismiss Difference" [X] button does nothing + spelling error in tooltip

Closed this issue 7 months ago · 7 comments

1.) When I click the "X" button next to the filename in the "Differences" menu, the file does not get removed from the list of files.
2.) "Dissmiss" should be "Dismiss" (one 's')

Answer 1 · 2024-03-23T18:55:23.000Z

Thanks for reporting 🙏
I'll check what's going on with the button and of course awill fix the typo

Answer 2 · 2024-03-23T21:07:32.000Z

Wow, that's amazing! Thanks for sharing
I'd be happy if you can fix these. It's alway more fun with collaboration
Let me know how it goes and if there is anything I can assist

Answer 3 · 2024-03-23T21:23:27.000Z

By the way, I verified that it's working on my mac. What's your environment?

Answer 4 · 2024-03-23T21:38:42.000Z

Windows 11, latest OS / VSCode versions.

Answer 5 · 2024-03-23T21:39:58.000Z

I'm installing the dependencies on my personal machine to modify the extension and test it (I just got a new laptop, so nothing is set up on it yet). So far I just have the spelling mistakes corrected, but I'll try to get the local clone of the extension running in VSCode to verify it's fixed. My hunch is that it's something in filterIgnoredFromDiffs() that is causing the issue.

Answer 6 · 2024-03-23T23:33:42.000Z

Looks like within dismissDifference = async (e: TreeItem) => {, path is possibly missing the drive letter at the beginning of the string

Answer 7 · 2024-04-02T18:47:28.000Z

fixed by #146

Thanks @sampellino for both the issue and the solution, you're the best 💪