mostjs/core

Warning of unsupported TypeScript version

Frikki opened this issue · 3 comments

@most/core version: 1.6.1

Steps To Reproduce

  1. Install Local Javascript Dependencies
npm install
  1. Run Tests
npm test

The Current Behavior

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.6.0

YOUR TYPESCRIPT VERSION: 3.9.7

Please only submit bug reports when using the officially supported version.

=============

The Expected Behavior

No warnings.

Suggestion

Three options:

A. Upgrade the @typescript-eslint/* packages to the latest versions, as the version range of TypeScript currently supported by their parser is >=3.3.1 <4.1.0.

B. Disable warning by configuring parserOptions.

C. Pin TypeScript dependency to <3.6.0.

In @most/core package.json, the related packages are pinned to version ^1.1.0, while several major releases have been issued since. E.g., the current version of @typescript-eslint/eslint-parser is 4.3.0. If we go for Option A, we should consider unpinning these packages in the dependencies, i.e., set their values to ^4.0.0.

Cast Your Vote



My vote would definitely be for option 1

Same, 1 seems like the way to go. Let's hope it doesn't turn into a huge ball of dependency string.

@briancavalier I expect it to, but hopefully not.