motou/magento2-store-locator-stockists-extension

Quick bug fix?

Opened this issue · 1 comments

mosaiceye commented

https://github.com/ClaudiuCreanga/magento2-store-locator-stockists-extension/blob/8bf464f7f380d74c7e0c3f4f9226eb2aa4774d26/src/view/frontend/web/js/limesharp_stockists.js#L106

Nice extension, I just noticed a quick bug @106:

BEFORE:
contentString += '<p class="ask-for-directions get-directions" data-directions="DRIVING">Get Directions</p>';

AFTER:
contentString += '<p class="ask-for-directions get-directions" data-directions="DRIVING"><a href="http://maps.google.com/maps?saddr=&daddr='+marker.getPosition().lat()+','+marker.getPosition().lng()+'" target="_blank">Get Directions</a></p>';

ClaudiuCreanga commented

@mosaiceye Thanks for this. Not sure if this is a bug. Your edit opens the directions on google maps or the maps application on mobile. As it is it works by displaying the directions on the website, not leaving the website. I agree that for mobile this is not ideal so probably it should be only for mobile..