Create a per-dashboard config

[armenzg]

Currently I have two different branches for two different projects:
https://firefox-performance-dashboard.netlify.com
https://awsy.netlify.com

I would like to either join both repos back or at least have different config files so I can merge changes from master into the awsy branch.

The file that conflicts between the two is src/config.js.

If we could have src/dashboards/awfy.js and src/dashboards/awsy.js it would be great!

[divyanshu-rawat]

Hey, @armenzg I am interested in this issue, let me know what it is about? and what you want? :)

[armenzg]

Hi @divyanshu-rawat thanks for your interest.

There are two branches on this repo: master and awsy. They each configure a different dashboard (see 1st comment). The configuration files for each dashboard is in their own branch:

• master branch
• awsy branch

If would be ideal to be able to start one dashboard or the other one from the same branch. In other words, only having the master branch. Perhaps we can do so by one of the following ideas (I don't know which one is possible):

• yarn start path/to/config.js
• yarn start name_of_dashboard (internally having an object that points to one of the two configs).

Let me know if this helps. Thanks!

[divyanshu-rawat]

cool @armenzg I will read through what you have mentioned in the comment and then let you know. 🙌

[divyanshu-rawat]

If we could have src/dashboards/awfy.js and src/dashboards/awsy.js it would be great!

Here in the last line what do you mean? it is the same file you are referring to. @armenzg

[divyanshu-rawat]

Hi @divyanshu-rawat thanks for your interest.

There are two branches on this repo: master and awsy. They each configure a different dashboard (see 1st comment). The configuration files for each dashboard is in their own branch:

• master branch
• awsy branch

If would be ideal to be able to start one dashboard or the other one from the same branch. In other words, only having the master branch. Perhaps we can do so by one of the following ideas (I don't know which one is possible):

• yarn start path/to/config.js
• yarn start name_of_dashboard (internally having an object that points to one of the two configs).

Let me know if this helps. Thanks!

If we want to start both of them from the same branch let's say master, then I think I have to migrate the config files of both the projects to master.

what should I name the config file of master branch for awsy branch I can name it awsy.js , currently I plan to name master config as master.js.

Something like src/config/awsy.js and src/config/master.js what do you think?,

[armenzg]

If we could have src/dashboards/awfy.js and src/dashboards/awsy.js it would be great!

Here in the last line what do you mean? it is the same file you are referring to. @armenzg

The names are very close, however, they're actually two differently named configs (to be created):

• Config from master --> src/config/awfy.js (Notice the 'f' instead of an 's')
• Config from awsy --> src/config/awsy.js (Notice the 's' instead of an 'f')

If we want to start both of them from the same branch let's say master, then I think I have to migrate the config files of both the projects to master.

You got it.

Something like src/config/awsy.js and src/config/master.js what do you think?,

Correct the 2nd name: master.js --> awfy.js

Thanks for looking into this! 👍

[divyanshu-rawat]

@armenzg I spent much time on this and managed to find a solution for the same, but later one solution was not working for awsy.js and realised that structure of config object is different in different branches what I mean is if you search for term dayRange in the config of master and in the config of awsy, then in the config of master you will 2 occurrences of it, and in the config of awsy you will find one as shown in attached snapshots.

AWSY

AWFY

Which implies that due to difference in object structure the code written in 2 different branches is different at some places, for example.

Here is the example -

This is Pickers component in master

So, the master one Picker component looks like this.

    <Picker
      key="Time range"
      identifier="numDays"
      topLabel="Time range"
      onSelection={onChange}
      selectedValue={dayRange}
      options={CONFIG.dayRange.map((numDays) => ({
        value: numDays,
        label: generateLastDaysLabel(numDays),
      }))}
    />

Have a look at options property, that points to CONFIG.dayRange in config in master, but CONFIG.dayRange doesn't exist in awsy config, so Picker component throws an error if you load the config file for awsy in master branch.

And This is the pickers component in awsy

[divyanshu-rawat]

One proposed solution is to add dayRange: [1, 2, 7, 14, 30, 60, 90, 365], in awsy as well, it will solve the problem and my solution to this issue will work. what do you say?

I have sent the PR, you can try running the app in localhost 😅

[armenzg]

Yes, that's a fine idea.
I will look at the PR on Monday since I'm off today. Thanks for your help!

[divyanshu-rawat]

cool @armenzg 👍

[armenzg]

We can now deploy both dashboard from the same code.
yay!
https://awsy.netlify.com/win10/overview?numDays=60

[armenzg]

I added DASHBOARD=awsy as an env variable and I pointed to master as the branch.
For now, I will keep the old branch.

[armenzg]

Hi,
I see an email notification asking me if I can see the contribution.
Is this it?

[divyanshu-rawat]

@armenzg I removed the comment thinking it doesn"t matter, but I was curious though that this contribution was not reflected at all, those 2 commits in the picture points to 2 different issues.

[armenzg]

I have ammended the commit and force pushed it. You might need to force pull if you had already updated to master.

[divyanshu-rawat]

Thanks @armenzg :) I wiil create new fork then to avoid issues ;)