Shared string in multiple context should turn into separate strings
Closed this issue ยท 6 comments
peiying2 commented
This string 30-day money-back guarantee is used multiple times on this page. For some languages, the translation is different depending on context. Let's break it up into types:
- Standalone string
- One of the bullet items
When a fix is added, let's make sure the string IDs and comments provide good context so it is clear which string is used where.
peiying2 commented
@craigcook feel free to triage the issue to the right person. Thank you!
craigcook commented
cc: @alexgibson
alexgibson commented
@peiying2 thanks, I'll see if we can get this fixed ๐
peiying2 commented
Maybe we keep this string by adding a comment where it's used. And the other is more specific in the string ID and add a comment. This way we don't lose the work of one string due to ID change.
alexgibson commented
PR for the change: mozilla/bedrock#10417
peiying2 commented
Looks good!