mozilla-mobile/focus-android

Backspace in URL search bar skips last character if URL autocomplete present

Closed this issue · 12 comments

rickydam commented

Steps to reproduce

  1. Build focus-android in Android Studio or install Firefox Focus from the Play Store
  2. Open the app
  3. Tap on SKIP on the top left
  4. Type moz into the URL search bar (the autocomplete should show illa.org highlighted in pink)
  5. Press backspace
  6. Press backspace again

Expected behavior

The first backspace erases the z and the second backspace erases the o.
The URL search bar should now show m.

Actual behavior

The first backspace skips the z and the second backspace erases the o.
The URL search bar now shows mz.

Device information

  • Android device: OnePlus5T, Oreo 8.1.0
  • Focus version: 7.0.13 (Latest Play Store version as of Nov 13, 2018) and v8.0 build#11

Extra information

  • Keyboard: Gboard v7.7.12.219989447-release-arm64-v8a (Latest Play Store version as of Nov 13, 2018)
  • All my autocorrect options are off except auto-capitalisation.

Would you like to turn on search suggestions? pop up by Firefox Focus is there and left untouched.

Different but related to closed issue #778 and closed pull request #2304

Video: https://drive.google.com/file/d/1vlAPMb1N7O1MdVOzL80ZWMq_mNoCRwB1/view?usp=sharing

ekager commented

Ah at first I thought this was the same as #778, but now I'm understanding what you're seeing.

The cursor goes to the wrong position when you press delete after it has autocompleted. I think this is a release blocker.

@vesta0 I'm moving this to a P1.

  • 👍1
sv-ohorvath commented

I can still reproduce this on Nightly & Beta 8.0.1 if I turn off everything related to Gboard auto-correct. If they are on, this doesn't happen.
Recording

sblatz commented

@ekager did this commit fix any variation of the issue?

To me this seems like an issue with the autocomplete Android component.

sblatz commented

I confirmed this is an android component issue, as I'm able to reproduce on the reference browser. Filed here: mozilla-mobile/android-components#1489

pocmo commented

Quick question about the priority: Since this seems to be confirmed for both 8.0 and the already released 7.0.x (and I wouldn't be surprised if earlier versions too): Is this indeed a release blocker?

sblatz commented

Good point, @pocmo. Pinging @vesta0.

vesta0 commented

@pocmo I agree and removed the label release blocker but this is still high priority. Thanks for looking into it.

mcomella commented

We spoke to Arturo: someone in SF will take care of this because we need to be able to test any fix on Echo Show as well.

Sdaswani commented

@vesta0 just confirming this is still a high priority? #3892 (comment)

vesta0 commented

@Sdaswani @mcomella yes it is. I didn't consider it to be a release blocker but it is definitely high priority and needs to be fixed. Thank you!

pocmo commented

A patch for that landed in 0.37.0 and is going to be released today. Removing the a-c label.

  • 👍1
sv-ohorvath commented

Verified as fixed on Nightly 9.0 GV 64.
Devices: Samsung Galaxy S8 (Android 8.0), HTC Desire 820 (Android 6.0.1)