mozilla-releng/balrog

show an indication when a rule points at a blob with wnp data (updateLine object)

Opened this issue · 5 comments

bhearsum commented

Since the what's new pages are now part of the blobs rather than rules, their presence is hidden, but can be relevant, so it'd be nice to retain some indication that a blob has that extra information.

(Imported from https://bugzilla.mozilla.org/show_bug.cgi?id=1445236)

Raven49 commented

Kindly assign this task to me

bhearsum commented

Hi, please feel free to work on the issue and open a PR when you feel it is ready.

nazarenegena commented

@bhearsum I have looked into this issue and went through the discussions here https://bugzilla.mozilla.org/show_bug.cgi?id=1445236. I would like to know if the api is returning the updateLine object which we can use to add more info on the blobs?

bhearsum commented

Nice digging! https://bugzilla.mozilla.org/show_bug.cgi?id=1445236#c4 is the most relevant comment there, and suggests this is maybe a bit more work than it looked:

  • The AppRelease blobs need a method to determine whether or not they contain a What's New Page. The implementation of this method will look different for different blob types. Eg: V9 needs to look through "updateLine". Earlier versions probably just need to look for "openURL". That code is in https://github.com/mozilla/balrog/blob/master/auslib/blobs/apprelease.py
  • The /rules endpoint needs to return whether or not each Mapping or Fallback Mapping contains a WNP. It might do this by calling the method above directly, or it may rely on the database layer having already done that. Each rule object in the response will need to contain a boolean attribute called something like "has_wnp". This code is in https://github.com/mozilla/balrog/blob/master/auslib/web/common/rules.py#L14

These are both fairly significant backend changes.

  • The UI needs to look for this new attribute, and show some visual indication for any rules that have it set to true.

This is a fairly straightforward frontend change, but can't be done without the backend changes.

I'm going to recommend that you consider looking at one of the other good first bugs instead - sorry about that.

nazarenegena commented

Thank you for the update.