mozilla-releng/balrog

busted dependencies for tests

escapewindow opened this issue · 4 comments

escapewindow commented

Not sure if this is true for prod or just tests, but

  • for 940d586 , tests are busted on an unpinned pyjwt even though it's pinned in base.txt, and
  • when @gabrielBusta and I tried to re-pin deps (with --allow-unsafe, we die on repoze-lru.

If there's a workaround, we can use it, but we may want to do something more invasive, e.g. find an alternative for repoze-lru.

gabrielBusta commented

I haven't been able to find a work around. repoze-lru hasn't been published since 2017. looking for an alternative (maybe the native lru cache in functools?)

escapewindow commented

Yeah, I think functools lru_cache will probably work.

jcristau commented

IIRC I hit issues with repose-lru vs repoze.lru in the requirements file a while back that I never quite understood, where one worked and the other didn't. That may not help here and may not even matter if we can switch to cachetools or something.

  • 👍1
  • 👀1
gabrielBusta commented

Ah I see. It's worth a try. Thanks