Emergency shutoff button is clickable when it is disabled
Closed this issue · 13 comments
Found while working on #2604 (maybe a good first bug)
When product/channel is not selected:
When updates is already disabled:
I am an outreach applicant, I don't see the first-bug issue available (all assigned or commented by applicants), so can I work on this issue?
Hey @gabrielBusta, can you assign this issue to @mays4 ?
It looks like a good-first-bug.
@gabrielBusta @bhearsum there has been no PR on this issue, can I work on it?
@allan-silva can you provide more context on which pages to look for, files to edit?
The fix will almost certainly be in https://github.com/mozilla-releng/balrog/blob/main/ui/src/views/Rules/ListRules/index.jsx#L137. Based on @allan-silva's earlier comment & screenshot it sounds like productChannelQueries may not be set when an emergency shutoff has been done. My suggestion would be to add some console.log messages to this file and then:
- Visit https://localhost:9000/rules?product=Firefox&channel=release
- Open the Developer Tools Console
- Reload the page, and make note of any log messages that show up
- Use "Disable updates" in the bottom right of the view to set the emergency shutoff
- Reload the page, and compare the log messages that show up this time
@bhearsum Thanks for your prompt response. Taking a look..
I tried to replicate the issue @bhearsum but there seems to be no issue with this. I followed the steps as well as @allan-silva's message and the page seems to be fine.
I had no errors in my debug tools when I disabled updates for a product (Firefox : Release) in my case, and then selected All Rules.
Maybe this has been fixed? Or I'm not replicating the issue correctly?
@MelakuAlehegn have you been able to replicate this issue?
Can't see any error that looks like the image @allan-silva shared
Hello everyone, try to reproduce in the following order:
- Click on rules;
- On rules page, select a product/channel (eg.: Firefox : Nightly);
- Click on "pause button" to disable product/channel updates;
- Optionally say the reason and click "Yes".
Now updates for product/channel are disabled.
- repeate the steps 3 and 4 (notice the pause button is disabled, but is clickable)
Ooooh ! Let me do this
@allan-silva it looks like the button is clickable for disabled updates, as you explained. Confirming that the error exists.
When Clicked again
Hi @bhearsum @gabrielBusta this ISSUE has been solved HERE and is safe to be closed now I guess. Bless y'all
Thanks, we missed that!