mozilla-releng/redo

Redundant logging for the first attempt

Closed this issue · 6 comments

patrickdepinguin commented

The retry method will add an 'info' log on every attempt, even on the first one. When all goes well, this pollutes the log.
What do you think of:
a. removing the log on the first attempt completely, or
b. reducing the log level of the first message to 'debug'
?

heyleke commented

I vote for "removing the log on the first attempt completely"

bhearsum commented

I can see the argument for both, but I think that moving the first attempt's log message to the DEBUG log level would be better. If I'm in debugging mode, I can see it being useful to be certain that my function is getting called via redo.

patrickdepinguin commented

Thanks for the feedback. Will you just change this in the code, or do you prefer a pull request?

bhearsum commented

If you could do a pull request that'd be great!

patrickdepinguin commented

Issue fixed with commit ee13b1d

Do you plan to release a new version to PyPI ?

bhearsum commented

Just released 1.4.1, thanks again!