mozilla-services/shavar

Filter out error messages generated from burpsuite

Closed this issue · 2 comments

say-yawn commented

About this Issue

After the pushing 0.13.2 to Prod on Friday we had thousands of error messages that bombarded the Shavar's Sentry. The most issues created from Sentry were errors with the following messages:

  • Invalid RANGE "1583447802%22--%3e'--%3e%60--%3e%3c!--%23set%20var%3d%229kg%22%20value%3d%228jf04x
  • Invalid LISTINFO for ads-track-digest256
  • Invalid list name: "{"7g5yf9":{"@type":"Lcom.sun.rowset.JdbcRowSetImpl"
    @ckolos brought up that these issues are happening likely due to someone running burpsuiteagainst Shavar and that the best way to prevent the issues surfacing on Sentry is to filter them out from the service side.

Acceptance Criteria

  • Filter out the following error messages from Shavar's prod Sentry
  • Invalid RANGE "1583447802%22--%3e'--%3e%60--%3e%3c!--%23set%20var%3d%229kg%22%20value%3d%228jf04x
  • Invalid LISTINFO for ads-track-digest256
  • Invalid list name: "{"7g5yf9":{"@type":"Lcom.sun.rowset.JdbcRowSetImpl"
say-yawn commented

Further discussion and testing with @jwhitlock showed that the issue with multiples issues being logged in Sentry even though they are the same "Invalid Range" error but with minor message differences was caused by the use of raven and using a custom Sentry logging handler. As a result, updating from raven to sentry_sdk should properly group the errors into a single issue and we can ignore that issue rather than suppressing it from the service.

say-yawn commented

Tested on staging, the events did not get grouped properly since the message was unique and there were no stack traces.