mozilla-services/shavar

Deprecate logger.error to .info to reduce Sentry events

Closed this issue · 1 comments

Some of these events are NOT necessarily and error, more like a warning and can be deprecated to warning or info:

  • Skipping {version num} version support for {list name} ...: this is to inform that there is a versioned branch on shavar-prod-list that on Shavar the list is not supported for the said version. This is an error if we expected that list to be available on Shavar but some of the lists should be skipped due to logic changes (e.g. entity list broken down to Google v. rest after version 74, email tracker lists only available after version 96, and so on). There are 108 errors on Sentry with this error format that has about 700-900 events per error.
  • No chunk file found at {s3 path+list name} ...: similar to the error above, this is to inform that there was no file in the following S3 path. This may be an expected behavior but could also be ignored. There are 70 errors with this error format that has about 700-900 events per error.

I decided to keep the No chunk file found ... as an error because this is a valid error that can happen if the Shavar server config is looking for files that is supposed to exist but is not yet in S3 which is the result of this error. This old Sentry errors show that the event stops after a while which shows that the lists were available in S3 and if it continued to not exist in S3 this is an error we should address.