mozilla/addons-linter

Move dispensary into the linter

tofumatt opened this issue · 4 comments

tofumatt commented

No one other than us seems to use https://github.com/mozilla/dispensary as a dependency. Updating it and the linter at the same time is a bit of a pain, so we should move dispensary into the linter to make updates easier.

ioanarusiczki commented

@willdurand In case this can be tested let me know.

willdurand commented

@ioanarusiczki yeah, you can submit an extension with a known file from the list: https://github.com/mozilla/addons-linter/blob/master/src/dispensary/hashes.txt

AlexandraMoga commented

@willdurand I've tested with a few of the files mentioned in https://github.com/mozilla/addons-linter/blob/master/src/dispensary/hashes.txt and compared the validation results from -dev and prod. There were no differences as far as I could tell.

Here are some examples:

  • validation messages when certain .js libraries are identified in the archive(*)
    image
    *a note on angular - I've checked a few libraries and for all of them I've received the "Banned js library" error:
    image

  • validation messages for invalid syntax:
    image

willdurand commented

@willdurand I've tested with a few of the files mentioned in master/src/dispensary/hashes.txt and compared the validation results from -dev and prod. There were no differences as far as I could tell.

No difference = good :)