Error since async is now a reserved keyword in python 3.7
txtsd opened this issue · 4 comments
txtsd commented
└─▶ ./cipherscan --sigalg mozilla.org
.......................................Traceback (most recent call last):
File "cscan.py", line 6, in <module>
from tlslite.messages import ClientHello, ServerHello, ServerHelloDone, Alert
File "/home/txtsd/git/cipherscan/tlslite/__init__.py", line 27, in <module>
from tlslite.api import *
File "/home/txtsd/git/cipherscan/tlslite/api.py", line 11, in <module>
from .tlsconnection import TLSConnection
File "/home/txtsd/git/cipherscan/tlslite/tlsconnection.py", line 112
async=False):
^
SyntaxError: invalid syntax
....
tomato42 commented
please use new tlslite-ng, version 0.7.2 was released specifically to fix this issue
txtsd commented
@tomato42 What is the relationship between cipherscan and tlslite-ng?
EDIT: Figured it out. Wouldn't it be better if tlslite-ng was a submodule, instead of having to go into the dot-directory and manually pulling the repo?
tomato42 commented
cipherscan uses tlslite-ng for some of its tests, we want to use the newest tlslite-ng, but we don't want to update it every time cipherscan is executed (as that has non-insignificant impact on the mass-scanning)
txtsd commented
Thanks for clearing it up.